test: fix test_get_domainname_isc_dhclient mock leak#6824
Closed
ani-sinha wants to merge 1 commit intocanonical:mainfrom
Closed
test: fix test_get_domainname_isc_dhclient mock leak#6824ani-sinha wants to merge 1 commit intocanonical:mainfrom
ani-sinha wants to merge 1 commit intocanonical:mainfrom
Conversation
Without mocking out dhcp.IscDhclient.get_newest_lease_file_from_distro, the functions on some platforms returns None. This means get_key_from_latest_lease() bails out early without calling parse_leases() to parse the lease file. Fix it. Signed-off-by: Ani Sinha <anisinha@redhat.com>
Contributor
Author
|
Sent as a part of #6829 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Without mocking out
dhcp.IscDhclient.get_newest_lease_file_from_distro, this function on some platforms returnsNoneas it is not able to find the lease files on the host. This meansget_key_from_latest_lease()bails out early without callingparse_leases()to parse the lease file. Fix it.Merge type